Add last checkouts to tabcompletion #641
Conversation
This adds functionality to suggest last used branches (and commits) when
tab completing "git checkout" command. This is inspired by "@{-N}" syntax that
you can use use now in git (for example "git checkout @{-1}" switch to last used
branch.
src/GitTabExpansion.ps1
Outdated
| @@ -101,6 +101,13 @@ function script:gitCommands($filter, $includeAliases) { | |||
| $cmdList | Sort-Object | |||
| } | |||
|
|
|||
| function script:lastCheckouts($filter){ | |||
| git reflog | | |||
There was a problem hiding this comment.
Two suggestions here:
- Specify an explicit
--format=%gs(I think?) to get only the log output you need. There might be other flags you can also specify to optimize the operation (e.g.--no-decorate). reflogcan get quite long under active development, so I would add a--max-count=<number>to avoid scanning thousands of references.
There was a problem hiding this comment.
I came up with two options and I'm not sure which will be better 🤔
git log --walk-reflogs --max-count=100 --format=%gs
get more number of reflogs and then search for "'checkout: moving from (.) to (.)'" pattern from result.git log --walk-reflogs --max-count=10 --grep-reflog='checkout: moving from ' --fixed-strings --format=%gs
get less number of reflogs but already filtered to one with data that we need (containing "checkout: moving from" in reflog subject).
For me option 2) seems more tempting because you get less data from git command. However the performance can depend on how big is you reflog and how many entries it has that are not what we are looking for (we want only reflogs with "checkout: moving from" subject). In other words you don't know how many reflogs git will traverse to get you list of 10 reflogs you want.
I think 2) is fine. How many crazy operations (like rebases of huge number of commits) you would have to do between switching branch 10 times to have huge reflog that can affect performance?
What do you think? Which option would you like to have?
We got this message from git when we ran git log command: "fatal: ambiguous argument 'moving': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'" This change in quoting fixes it.
|
I ended up with implementing seconds options as it seams "good enough" for me (for example for my repo I work on now I have reflog with over 600 entries and without BTW. I broke and fixed unit test that I wrote before, but I actually don't know why previous quoting broke unit test... When I executed both quote variants in terminal they run fine... 🤔 |
Hi, thanks for this great project!
I think this small feature will make it even better ;-)
I really like git
@{-N}syntax to checkout last used branches. I thought that if posh-git could suggest this last used branches first we would have nice user experience. You could justTabandShift+Taband quickly choose the recent branch you need to work on again.It would be very useful when you work on a lot of branches that have long names and you don't remember the name correctly (for example because it has Jira key at beginning, and who remembers that ;-)).
It looks that git source code does something very similar to what I have done here to get last checkout commits.